]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: tegra: Fix a memory leak in tegra_slink_probe()
authorFelix Gu <ustc.gu@gmail.com>
Mon, 2 Feb 2026 15:15:09 +0000 (23:15 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 2 Feb 2026 15:47:07 +0000 (15:47 +0000)
In tegra_slink_probe(), when platform_get_irq() fails, it directly
returns from the function with an error code, which causes a memory leak.

Replace it with a goto label to ensure proper cleanup.

Fixes: eb9913b511f1 ("spi: tegra: Fix missing IRQ check in tegra_slink_probe()")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://patch.msgid.link/20260202-slink-v1-1-eac50433a6f9@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra20-slink.c

index fe452d03c1ee4335951947550e2f3447505a89b0..709669610840bc5d937f6b7216d3acd3434b293a 100644 (file)
@@ -1086,8 +1086,10 @@ static int tegra_slink_probe(struct platform_device *pdev)
        reset_control_deassert(tspi->rst);
 
        spi_irq = platform_get_irq(pdev, 0);
-       if (spi_irq < 0)
-               return spi_irq;
+       if (spi_irq < 0) {
+               ret = spi_irq;
+               goto exit_pm_put;
+       }
        tspi->irq = spi_irq;
        ret = request_threaded_irq(tspi->irq, tegra_slink_isr,
                                   tegra_slink_isr_thread, IRQF_ONESHOT,