]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: syscon: remove unneeded call to platform_set_drvdata()
authorAndrei Coardos <aboutphysycs@gmail.com>
Tue, 1 Aug 2023 07:30:44 +0000 (10:30 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 3 Aug 2023 13:44:49 +0000 (15:44 +0200)
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-syscon.c

index 41bf47c8c98343c3a100c4f896029438b3d285c0..6e1a2581e6aeb55c58cd5c720cab2fd62a6bb5f7 100644 (file)
@@ -248,8 +248,6 @@ static int syscon_gpio_probe(struct platform_device *pdev)
                priv->chip.direction_output = syscon_gpio_dir_out;
        }
 
-       platform_set_drvdata(pdev, priv);
-
        return devm_gpiochip_add_data(&pdev->dev, &priv->chip, priv);
 }