]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
dbus-unit: don't eat up error codes needlessly
authorLennart Poettering <lennart@poettering.net>
Tue, 16 Jan 2024 22:16:40 +0000 (23:16 +0100)
committerLennart Poettering <lennart@poettering.net>
Wed, 17 Jan 2024 10:32:11 +0000 (11:32 +0100)
src/core/dbus-unit.c

index 3aeb85e45248e146f4bbc6a9ee0adba6647f20a9..7aa44b2393e445ec83d050473bad4c249e5fe8da 100644 (file)
@@ -2271,7 +2271,9 @@ static int bus_unit_set_transient_property(
                                 u->documentation = strv_free(u->documentation);
                                 unit_write_settingf(u, flags, name, "%s=", name);
                         } else {
-                                strv_extend_strv(&u->documentation, l, false);
+                                r = strv_extend_strv(&u->documentation, l, /* filter_duplicates= */ false);
+                                if (r < 0)
+                                        return r;
 
                                 STRV_FOREACH(p, l)
                                         unit_write_settingf(u, flags, name, "%s=%s", name, *p);