]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Fix message packing error handling in mgr and snmp SMP Forwarders.
authorAlex Rousskov <rousskov@measurement-factory.com>
Sat, 1 Jul 2017 08:11:16 +0000 (20:11 +1200)
committerAmos Jeffries <squid3@treenet.co.nz>
Sat, 1 Jul 2017 08:11:16 +0000 (20:11 +1200)
A missing "return" resulted in Forwarders sending garbage (or worse) to
Coordinator.

src/ipc/Forwarder.cc

index 13e051fff3db816d3bb278e89508c31233bc683b..58a72915fa37f7483098b9a66fdf5bd004bb8107 100644 (file)
@@ -62,6 +62,7 @@ Ipc::Forwarder::start()
         // assume the pack() call failed because the message did not fit
         // TODO: add a more specific exception?
         handleError();
+        return;
     }
 
     SendMessage(Ipc::Port::CoordinatorAddr(), message);