]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Fix sqlite memory req
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 30 Mar 2020 19:04:53 +0000 (15:04 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 30 Mar 2020 19:05:35 +0000 (15:05 -0400)
this is only used by test/requirements.py right now for the
profiling tests but it was not returning the correct answer
during a regenerate operation.

Change-Id: Id9747b4fe562b8bea9b21c465b626b1b19e6956b
(cherry picked from commit 379e878c5854f8d0b4e65338571ba03986901ba8)

test/requirements.py

index 7ab2b305fc60c1a1ca3b03348752b47536e7c581..ea6eee6fb89302f30a8f3d8a44e4dc64d7a21edb 100644 (file)
@@ -884,7 +884,9 @@ class DefaultRequirements(SuiteRequirements):
         )
 
     def _sqlite_memory_db(self, config):
-        return not self._sqlite_file_db(config)
+        return against(
+            config, "sqlite"
+        ) and not config.db.dialect._is_url_file_db(config.db.url)
 
     def _sqlite_json(self, config):
         if not against(config, "sqlite >= 3.9"):