Merge pull request #2768 in SNORT/snort3 from ~SHRARANG/snort3:appid_cppcheck to...

Squashed commit of the following:

commit 540aa99530d3d7e9ff6282691891553fcb9153da
Author: Shravan Rangaraju <shrarang@cisco.com>
Date:   Fri Feb 26 12:41:42 2021 -0500

    appid: fixes for cppcheck warnings

diff --git a/src/network_inspectors/appid/test/appid_discovery_test.cc b/src/network_inspectors/appid/test/appid_discovery_test.cc
index d23faa2d69204a50d4dd007bd09375537f66b6fd..6504b51a632ca4c6ff849c40e6e471f309416736 100644 (file)
--- a/src/network_inspectors/appid/test/appid_discovery_test.cc
+++ b/src/network_inspectors/appid/test/appid_discovery_test.cc
@@ -275,11 +275,6 @@ TPLibHandler* TPLibHandler::self = nullptr;
 THREAD_LOCAL AppIdStats appid_stats;
 THREAD_LOCAL AppIdDebug* appidDebug = nullptr;
 void AppIdDebug::activate(const Flow*, const AppIdSession*, bool) { active = false; }
-void check_session_for_AF_indicator(Packet*, AppidSessionDirection, AppId, const OdpContext&) {}
-AppId check_session_for_AF_forecast(AppIdSession&, Packet*, AppidSessionDirection, AppId)
-{
-    return APP_ID_UNKNOWN;
-}
 
 bool AppIdReloadTuner::tinit() { return false; }