]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
coverity: #1425764
authorChristian Brauner <christian.brauner@ubuntu.com>
Fri, 15 Jun 2018 09:29:52 +0000 (11:29 +0200)
committerChristian Brauner <christian.brauner@ubuntu.com>
Fri, 15 Jun 2018 09:39:40 +0000 (11:39 +0200)
Unchecked return value

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
src/lxc/lxccontainer.c

index de4a49e62997c64f90c240b8d1baf8825a671bc8..b974deb9ba010a46860a1cca5fad6c732aba0566 100644 (file)
@@ -1561,15 +1561,24 @@ static bool create_run_template(struct lxc_container *c, char *tpath,
 
                        /* note n2[n2args-1] is NULL */
                        n2[n2args - 5] = "--mapped-uid";
-                       snprintf(txtuid, 20, "%d", hostuid_mapped);
+
+                       ret = snprintf(txtuid, 20, "%d", hostuid_mapped);
+                       if (ret < 0 || ret >= 20) {
+                               free(newargv);
+                               free(n2);
+                               _exit(EXIT_FAILURE);
+                       }
+
                        n2[n2args - 4] = txtuid;
                        n2[n2args - 3] = "--mapped-gid";
+
                        ret = snprintf(txtgid, 20, "%d", hostgid_mapped);
                        if (ret < 0 || ret >= 20) {
                                free(newargv);
                                free(n2);
                                _exit(EXIT_FAILURE);
                        }
+
                        n2[n2args - 2] = txtgid;
                        n2[n2args - 1] = NULL;
                        free(newargv);