add comment, intermediate var for readability

diff --git a/lib/sqlalchemy/topological.py b/lib/sqlalchemy/topological.py
index 56c8cb46e4491931585ce17a3fa0c7ed592884c6..dcfe9ea7158713bd460c607e1b659357970ea8cd 100644 (file)
--- a/lib/sqlalchemy/topological.py
+++ b/lib/sqlalchemy/topological.py
@@ -307,9 +307,9 @@ class QueueDependencySorter(object):
         for parent in edges.get_parents():
             traverse(parent)
 
-        for cycle in dict([(id(s), s) for s in cycles.values()]).values():
-            edgecollection = []
-            for edge in edges:
-                if edge[0] in cycle and edge[1] in cycle:
-                    edgecollection.append(edge)
+        # sets are not hashable, so uniquify with id
+        unique_cycles = dict([(id(s), s) for s in cycles.values()]).values()
+        for cycle in unique_cycles:
+            edgecollection = [edge for edge in edges
+                              if edge[0] in cycle and edge[1] in cycle]
             yield edgecollection