]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: qla2xxx: edif: Fix incorrect sign of error code
authorQianfeng Rong <rongqianfeng@vivo.com>
Fri, 5 Sep 2025 07:54:43 +0000 (15:54 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Oct 2025 09:56:34 +0000 (11:56 +0200)
[ Upstream commit 066b8f3fa85c1be7fb7dbae202231e131d38f7bc ]

Change the error code EAGAIN to -EAGAIN in qla24xx_sadb_update() and
qla_edif_process_els() to align with qla2x00_start_sp() returning
negative error codes or QLA_SUCCESS, preventing logical errors.

Fixes: 0b3f3143d473 ("scsi: qla2xxx: edif: Add retry for ELS passthrough")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Message-ID: <20250905075446.381139-2-rongqianfeng@vivo.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/qla2xxx/qla_edif.c

index 969008071decdf8c43b09886c964362cc43a7c55..482c04ac06ba4172bcd2b6354c4152ffa72f7f28 100644 (file)
@@ -1755,7 +1755,7 @@ retry:
        switch (rval) {
        case QLA_SUCCESS:
                break;
-       case EAGAIN:
+       case -EAGAIN:
                msleep(EDIF_MSLEEP_INTERVAL);
                cnt++;
                if (cnt < EDIF_RETRY_COUNT)
@@ -3621,7 +3621,7 @@ retry:
                       p->e.extra_rx_xchg_address, p->e.extra_control_flags,
                       sp->handle, sp->remap.req.len, bsg_job);
                break;
-       case EAGAIN:
+       case -EAGAIN:
                msleep(EDIF_MSLEEP_INTERVAL);
                cnt++;
                if (cnt < EDIF_RETRY_COUNT)