Fix: setting empty doc link with docs to be removed (#5174)

diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py
index c07b00f78f3bdc5c60ce6e845e41b6fdbac1c3c9..5e80379600afd489c329463e1e512f0e2464aaf0 100644 (file)
--- a/src/documents/serialisers.py
+++ b/src/documents/serialisers.py
@@ -527,6 +527,10 @@ class CustomFieldInstanceSerializer(serializers.ModelSerializer):
         """
         Add or remove 'symmetrical' links to `document` on all `target_doc_ids`
         """
+
+        if target_doc_ids is None:
+            target_doc_ids = []
+
         # Check if any documents are going to be removed from the current list of links and remove the symmetrical links
         current_field_instance = CustomFieldInstance.objects.filter(
             field=field,
@@ -540,9 +544,6 @@ class CustomFieldInstanceSerializer(serializers.ModelSerializer):
                 if doc_id not in target_doc_ids:
                     self.remove_doclink(document, field, doc_id)
 
-        if target_doc_ids is None:
-            target_doc_ids = []
-
         # Create an instance if target doc doesnt have this field or append it to an existing one
         existing_custom_field_instances = {
             custom_field.document_id: custom_field