]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
ovpnmain.cgi: Fix iterating over the DHCP CCD options
authorMichael Tremer <michael.tremer@ipfire.org>
Thu, 30 Oct 2025 11:40:16 +0000 (12:40 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Thu, 30 Oct 2025 16:36:24 +0000 (17:36 +0100)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
html/cgi-bin/ovpnmain.cgi

index 3b3776aaad0771160830799dcb5fc14e988cf8bd..fa5ef295a115eb7057c365a30d5d8b8157d24acd 100644 (file)
@@ -677,24 +677,24 @@ sub write_ccd_configs() {
 
                # DHCP Options
                my %options = (
-                       "DNS" => (
+                       "DNS" => [
                                $conns{$key}[35],
                                $conns{$key}[36],
-                       ),
+                       ],
 
-                       "WINS" => (
+                       "WINS" => [
                                $conns{$key}[37],
-                       ),
+                       ],
                );
 
                print CONF "# DHCP Options\n";
 
                foreach my $option (keys %options) {
-                       foreach (@options{$option}) {
-                               # Skip empty options
-                               next if ($_ eq "");
+                       foreach my $address (@{ $options{$option} }) {
+                               # Skip empty addresses
+                               next if ($address eq "");
 
-                               print CONF "push \"dhcp-option $option $_\"\n";
+                               print CONF "push \"dhcp-option $option $address\"\n";
                        }
                }