]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: dwc3: google: Remove redundant dev_err()
authorChen Ni <nichen@iscas.ac.cn>
Thu, 15 Jan 2026 02:38:00 +0000 (10:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jan 2026 16:16:05 +0000 (17:16 +0100)
The platform_get_irq_byname() function already prints an error message
internally upon failure using dev_err_probe(). Therefore, the explicit
dev_err() is redundant and results in duplicate error logs.

Remove the redundant dev_err() call to clean up the error path.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://patch.msgid.link/20260115023800.4142416-1-nichen@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-google.c

index a19857bd6b131d841d165717b70f2959b4bac806..2105c72af7532746116760664afe30506c5e830f 100644 (file)
@@ -228,10 +228,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
        int irq;
 
        irq = platform_get_irq_byname(pdev, irq_name);
-       if (irq < 0) {
-               dev_err(google->dev, "invalid irq name %s\n", irq_name);
+       if (irq < 0)
                return irq;
-       }
 
        irq_set_status_flags(irq, IRQ_NOAUTOEN);
        ret = devm_request_threaded_irq(google->dev, irq, NULL,