]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
mod-whoami: remove redundant check (lgtm.com)
authorDaniel Salzman <daniel.salzman@nic.cz>
Tue, 20 Mar 2018 08:15:03 +0000 (09:15 +0100)
committerDaniel Salzman <daniel.salzman@nic.cz>
Tue, 20 Mar 2018 08:15:03 +0000 (09:15 +0100)
src/knot/modules/whoami/whoami.c

index 1a43e12e62d47a05b9af3c6fc1d6cb6c3d6468cd..ea80fc963e3c9976200ecda1f81b7254b95dd374 100644 (file)
@@ -59,7 +59,7 @@ static knotd_in_state_t whoami_query(knotd_in_state_t state, knot_pkt_t *pkt,
         * length into 'rdata' and 'len_rdata'.
         */
        const void *rdata = NULL;
-       size_t len_rdata = 0;
+       uint16_t len_rdata = 0;
        if (query_source->ss_family == AF_INET && qtype == KNOT_RRTYPE_A) {
                const struct sockaddr_in *sai = (struct sockaddr_in *)query_source;
                rdata = &sai->sin_addr.s_addr;
@@ -73,13 +73,6 @@ static knotd_in_state_t whoami_query(knotd_in_state_t state, knot_pkt_t *pkt,
                return state;
        }
 
-       /* Sanity check, since knot_rrset_add_rdata() takes a uint16_t length
-        * parameter.
-        */
-       if (len_rdata > UINT16_MAX) {
-               return state;
-       }
-
        /* Synthesize the response RRset. */
 
        /* TTL is taken from the TTL of the SOA record. */