[#3256] address review

diff --git a/src/lib/cc/data.cc b/src/lib/cc/data.cc
index b7bc6c399abeb50776d4583f778afcc41a14e001..f48bed5e8181bded7839bd9911bc22775f34a6cc 100644 (file)
--- a/src/lib/cc/data.cc
+++ b/src/lib/cc/data.cc
@@ -902,7 +902,7 @@ StringElement::toJSON(std::ostream& ss) const {
             ss << '\\' << 't';
             break;
         default:
-            if (((c >= 0) && (c < 0x20)) || (c < 0) || (c >= 0x7f)) {
+            if (c < 0x20 || c == 0x7f) {
                 std::ostringstream esc;
                 esc << "\\u"
                     << hex

diff --git a/src/lib/http/http_message_parser_base.cc b/src/lib/http/http_message_parser_base.cc
index cbda31a01301cb77ecc23eafc501209bf832b939..284e847b767acb6d2f9071a3257de6aafc521fac 100644 (file)
--- a/src/lib/http/http_message_parser_base.cc
+++ b/src/lib/http/http_message_parser_base.cc
@@ -262,7 +262,6 @@ HttpMessageParserBase::popNextFromBuffer(std::string& next, const size_t limit)
 
 bool
 HttpMessageParserBase::isChar(const signed char c) const {
-    // was (c >= 0) && (c <= 127)
     return (c >= 0);
 }