]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
filestore: fix leak in contructing json
authorJason Ish <ish@unx.ca>
Sat, 4 May 2019 13:48:46 +0000 (07:48 -0600)
committerVictor Julien <victor@inliniac.net>
Sun, 5 May 2019 08:22:10 +0000 (10:22 +0200)
Use json_array_append_new instead of json_array_append to transfer
ownership of the integer object to jansson so it gets freed.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/2961

src/output-json-file.c

index 3283a2f3106aa5510b253bdc26e250edfb0f17df..79004fe04457ed6f5a7d63c2443183e5cbd304d3 100644 (file)
@@ -156,7 +156,7 @@ json_t *JsonBuildFileInfoRecord(const Packet *p, const File *ff,
     }
 
     for (uint32_t i = 0; ff->sid != NULL && i < ff->sid_cnt; i++) {
-        json_array_append(sig_ids, json_integer(ff->sid[i]));
+        json_array_append_new(sig_ids, json_integer(ff->sid[i]));
     }
     json_object_set_new(fjs, "sid", sig_ids);