]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
mmc: fsl_esdhc_imx: Cannot test unsigned to be < 0
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Tue, 21 Oct 2025 16:08:26 +0000 (17:08 +0100)
committerTom Rini <trini@konsulko.com>
Thu, 4 Dec 2025 15:38:16 +0000 (09:38 -0600)
Testing an unisgned member of a struct to be <= 0 will only detect the
case when it is 0. So correct this error test to a working version that
will behave as expected.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
drivers/mmc/fsl_esdhc_imx.c

index 926113f79d363a3e69bcb3ca46fb8fb3c2178e91..7dc76563b7e43f692d709a299e006ed0e2d6f3b7 100644 (file)
@@ -1543,7 +1543,7 @@ static int fsl_esdhc_probe(struct udevice *dev)
        init_clk_usdhc(dev_seq(dev));
 
        priv->sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK + dev_seq(dev));
-       if (priv->sdhc_clk <= 0) {
+       if (!priv->sdhc_clk || IS_ERR_VALUE(priv->sdhc_clk)) {
                dev_err(dev, "Unable to get clk for %s\n", dev->name);
                return -EINVAL;
        }