]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dmaengine: ti: k3-udma: fix device leak on udma lookup
authorJohan Hovold <johan@kernel.org>
Mon, 17 Nov 2025 16:12:58 +0000 (17:12 +0100)
committerVinod Koul <vkoul@kernel.org>
Sun, 14 Dec 2025 09:17:25 +0000 (14:47 +0530)
Make sure to drop the reference taken when looking up the UDMA platform
device.

Note that holding a reference to a platform device does not prevent its
driver data from going away so there is no point in keeping the
reference after the lookup helper returns.

Fixes: d70241913413 ("dmaengine: ti: k3-udma: Add glue layer for non DMAengine users")
Fixes: 1438cde8fe9c ("dmaengine: ti: k3-udma: add missing put_device() call in of_xudma_dev_get()")
Cc: stable@vger.kernel.org # 5.6: 1438cde8fe9c
Cc: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251117161258.10679-17-johan@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ti/k3-udma-private.c

index 05228bf00033329f9e466d3492ea7a26358f5f3c..624360423ef170104d7757b5a621442ff6bfbf3d 100644 (file)
@@ -42,9 +42,9 @@ struct udma_dev *of_xudma_dev_get(struct device_node *np, const char *property)
        }
 
        ud = platform_get_drvdata(pdev);
+       put_device(&pdev->dev);
        if (!ud) {
                pr_debug("UDMA has not been probed\n");
-               put_device(&pdev->dev);
                return ERR_PTR(-EPROBE_DEFER);
        }