]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915: rename t into tap
authorMichał Grzelak <michal.grzelak@intel.com>
Sat, 9 May 2026 16:40:42 +0000 (18:40 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 20 May 2026 23:52:47 +0000 (02:52 +0300)
Add more description to the casf_coeff()'s argument and
casf_coeff_tap()'s returned value.

Do the same for glk_nearest_filter_coef().

v1->v2
- apply the rename to nearest neighbor filter (Ville)

Cc: Nemesa Garg <nemesa.garg@intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260509164048.627399-4-michal.grzelak@intel.com
drivers/gpu/drm/i915/display/intel_casf.c
drivers/gpu/drm/i915/display/skl_scaler.c

index c4fabffa369e35a4eebd13baa00519c145cd87a8..b9643548d182200974fe37e04cf1d1489be186e0 100644 (file)
@@ -148,12 +148,12 @@ static int casf_coeff_tap(int i)
        return i % SCALER_FILTER_NUM_TAPS;
 }
 
-static u32 casf_coeff(const struct intel_crtc_state *crtc_state, int t)
+static u32 casf_coeff(const struct intel_crtc_state *crtc_state, int tap)
 {
        struct scaler_filter_coeff value;
        u32 coeff;
 
-       value = crtc_state->pch_pfit.casf.coeff[t];
+       value = crtc_state->pch_pfit.casf.coeff[tap];
        value.sign = 0;
 
        coeff = value.sign << 15 | value.exp << 12 | value.mantissa << 3;
@@ -183,13 +183,13 @@ static void intel_casf_write_coeff(const struct intel_crtc_state *crtc_state)
 
        for (i = 0; i < 17 * SCALER_FILTER_NUM_TAPS; i += 2) {
                u32 tmp;
-               int t;
+               int tap;
 
-               t = casf_coeff_tap(i);
-               tmp = casf_coeff(crtc_state, t);
+               tap = casf_coeff_tap(i);
+               tmp = casf_coeff(crtc_state, tap);
 
-               t = casf_coeff_tap(i + 1);
-               tmp |= casf_coeff(crtc_state, t) << 16;
+               tap = casf_coeff_tap(i + 1);
+               tmp |= casf_coeff(crtc_state, tap) << 16;
 
                intel_de_write_fw(display, GLK_PS_COEF_DATA_SET(crtc->pipe, id, 0),
                                  tmp);
index 308b8d363bba0368e66f866563a87e9b4ba2968b..eceda1a909ccd2d49f2d05508cb3cf616b6fd639 100644 (file)
@@ -661,9 +661,9 @@ static int glk_coef_tap(int i)
        return i % 7;
 }
 
-static u16 glk_nearest_filter_coef(int t)
+static u16 glk_nearest_filter_coef(int tap)
 {
-       return t == 3 ? 0x0800 : 0x3000;
+       return tap == 3 ? 0x0800 : 0x3000;
 }
 
 /*
@@ -715,13 +715,13 @@ static void glk_program_nearest_filter_coefs(struct intel_display *display,
 
        for (i = 0; i < 17 * 7; i += 2) {
                u32 tmp;
-               int t;
+               int tap;
 
-               t = glk_coef_tap(i);
-               tmp = glk_nearest_filter_coef(t);
+               tap = glk_coef_tap(i);
+               tmp = glk_nearest_filter_coef(tap);
 
-               t = glk_coef_tap(i + 1);
-               tmp |= glk_nearest_filter_coef(t) << 16;
+               tap = glk_coef_tap(i + 1);
+               tmp |= glk_nearest_filter_coef(tap) << 16;
 
                intel_de_write_dsb(display, dsb,
                                   GLK_PS_COEF_DATA_SET(pipe, id, set), tmp);