]> git.ipfire.org Git - thirdparty/snort3.git/commitdiff
Pull request #3703: appid: do not create snmp future flow for udp reversed traffic
authorSreeja Athirkandathil Narayanan (sathirka) <sathirka@cisco.com>
Tue, 20 Dec 2022 15:25:31 +0000 (15:25 +0000)
committerSreeja Athirkandathil Narayanan (sathirka) <sathirka@cisco.com>
Tue, 20 Dec 2022 15:25:31 +0000 (15:25 +0000)
Merge in SNORT/snort3 from ~SATHIRKA/snort3:snmp_ff to master

Squashed commit of the following:

commit cd4c269b5e8dc1f86f982509f373ce1ffe3beb4f
Author: Sreeja Athirkandathil Narayanan <sathirka@cisco.com>
Date:   Tue Dec 13 10:01:31 2022 -0500

    appid: do not create snmp future flow for udp reversed session

src/network_inspectors/appid/service_plugins/service_snmp.cc

index f6d10c911bc21eb3f241788bd696e9add8a62dd0..737c3629dd46e28efadac18645fcf82289406f31 100644 (file)
@@ -441,7 +441,8 @@ int SnmpServiceDetector::validate(AppIdDiscoveryArgs& args)
             args.asd.set_session_flags(APPID_SESSION_UDP_REVERSED);
             break;
         }
-        if (pdu == SNMP_PDU_GET_RESPONSE && args.dir == APP_ID_FROM_INITIATOR)
+        if ((pdu == SNMP_PDU_GET_RESPONSE or pdu == SNMP_PDU_REPORT) &&
+            args.dir == APP_ID_FROM_INITIATOR)
         {
             sd->state = SNMP_STATE_R_REQUEST;
             args.asd.set_session_flags(APPID_SESSION_UDP_REVERSED);