]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Coverity defect 1151594: side-effect in assertion in CollapsedForwarding
authorFrancesco Chemolli <kinkie@squid-cache.org>
Fri, 10 Jan 2014 19:01:04 +0000 (20:01 +0100)
committerFrancesco Chemolli <kinkie@squid-cache.org>
Fri, 10 Jan 2014 19:01:04 +0000 (20:01 +0100)
src/CollapsedForwarding.cc

index 29c30e5feb6ca38882a929444c599d70f27ff95d..a3aa4a1e800ece698d703465d32a23eb429ace9d 100644 (file)
@@ -110,7 +110,8 @@ CollapsedForwarding::HandleNewData(const char *const when)
         debugs(17, 7, "handled entry " << msg.xitIndex << " in transients_map");
 
         // XXX: stop and schedule an async call to continue
-        assert(++poppedCount < SQUID_MAXFD);
+        ++poppedCount;
+        assert(poppedCount < SQUID_MAXFD);
     }
 }