]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
compat: Add non-None queryset attribute
authorStephen Finucane <stephen@that.guru>
Tue, 4 Apr 2017 21:38:18 +0000 (22:38 +0100)
committerStephen Finucane <stephen@that.guru>
Fri, 28 Apr 2017 21:20:03 +0000 (22:20 +0100)
Older versions of Django REST Framework's 'RelatedField' did not check
for the presence 'get_queryset' before checking for a 'queryset'
attribute. This was fixed in 3.4.0 [1] and backported to the 3.3 series
in 3.3.3 [2]. However, the fix was not backported to the last release of
3.2 series [3], which is the last release to support Django 1.6. As
such, we must set a 'queryset' attribute, even if it's set to a garbage
value.

[1] ../blob/3.4.0/rest_framework/relations.py#L78-L82
[2] ../blob/3.3.3/rest_framework/relations.py#L78-L82
[3] ../blob/3.2.5/rest_framework/relations.py#L64-L67

Signed-off-by: Stephen Finucane <stephen@that.guru>
Closes-bug: #94

patchwork/api/patch.py

index ded491014ea01a5fb882e970200cea0d778c675e..fa6fb46fbc173c5ac5c2558c7f7de61ce2dfb992 100644 (file)
@@ -53,6 +53,7 @@ class StateField(RelatedField):
         'incorrect_type': _('Incorrect type. Expected string value, received '
                             '{data_type}.'),
     }
+    queryset = ''  # django 1.6, rest_framework 3.2 require this
 
     def to_internal_value(self, data):
         try: