]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
sched: Convert CONFIG_RT_GROUP_SCHED macros to code conditions
authorMichal Koutný <mkoutny@suse.com>
Mon, 10 Mar 2025 17:04:33 +0000 (18:04 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 8 Apr 2025 18:55:52 +0000 (20:55 +0200)
Convert the blocks guarded by macros to regular code so that the RT
group code gets more compile validation. Reasoning is in
Documentation/process/coding-style.rst 21) Conditional Compilation.
With that, no functional change is expected.

Signed-off-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20250310170442.504716-2-mkoutny@suse.com
kernel/sched/rt.c
kernel/sched/syscalls.c

index fa03ec3ed56a204033be2e07264844112298e7b8..2ade81e69db0a8640fd7bacb16beaec1524696c2 100644 (file)
@@ -1066,13 +1066,12 @@ inc_rt_prio_smp(struct rt_rq *rt_rq, int prio, int prev_prio)
 {
        struct rq *rq = rq_of_rt_rq(rt_rq);
 
-#ifdef CONFIG_RT_GROUP_SCHED
        /*
         * Change rq's cpupri only if rt_rq is the top queue.
         */
-       if (&rq->rt != rt_rq)
+       if (IS_ENABLED(CONFIG_RT_GROUP_SCHED) && &rq->rt != rt_rq)
                return;
-#endif
+
        if (rq->online && prio < prev_prio)
                cpupri_set(&rq->rd->cpupri, rq->cpu, prio);
 }
@@ -1082,13 +1081,12 @@ dec_rt_prio_smp(struct rt_rq *rt_rq, int prio, int prev_prio)
 {
        struct rq *rq = rq_of_rt_rq(rt_rq);
 
-#ifdef CONFIG_RT_GROUP_SCHED
        /*
         * Change rq's cpupri only if rt_rq is the top queue.
         */
-       if (&rq->rt != rt_rq)
+       if (IS_ENABLED(CONFIG_RT_GROUP_SCHED) && &rq->rt != rt_rq)
                return;
-#endif
+
        if (rq->online && rt_rq->highest_prio.curr != prev_prio)
                cpupri_set(&rq->rd->cpupri, rq->cpu, rt_rq->highest_prio.curr);
 }
index c326de1344fb72dbd0820f448f33b9b95d13d7a6..2bf528116fad2d5e52bc41517c1255acc85ee19f 100644 (file)
@@ -640,7 +640,7 @@ change:
                        retval = -EPERM;
                        goto unlock;
                }
-#endif
+#endif /* CONFIG_RT_GROUP_SCHED */
 #ifdef CONFIG_SMP
                if (dl_bandwidth_enabled() && dl_policy(policy) &&
                                !(attr->sched_flags & SCHED_FLAG_SUGOV)) {