posix writer: when creating hardinks call open() on regular files only

Fixes #724

diff --git a/libarchive/archive_write_disk_posix.c b/libarchive/archive_write_disk_posix.c
index 49e79dc23e9d3038cf7ac97926d719b774a0f405..20450bafcb0fed7c52df6c7f4577759b9a4b9b10 100644 (file)
--- a/libarchive/archive_write_disk_posix.c
+++ b/libarchive/archive_write_disk_posix.c
@@ -2067,6 +2067,7 @@ create_filesystem_object(struct archive_write_disk *a)
        int r;
        /* these for check_symlinks_fsobj */
        char *linkname_copy;    /* non-const copy of linkname */
+       struct stat st;
        struct archive_string error_string;
        int error_number;
 
@@ -2131,11 +2132,20 @@ create_filesystem_object(struct archive_write_disk *a)
                        a->todo = 0;
                        a->deferred = 0;
                } else if (r == 0 && a->filesize > 0) {
-                       a->fd = open(a->name, O_WRONLY | O_TRUNC | O_BINARY
-                           | O_CLOEXEC | O_NOFOLLOW);
-                       __archive_ensure_cloexec_flag(a->fd);
-                       if (a->fd < 0)
+#ifdef HAVE_LSTAT
+                       r = lstat(a->name, &st);
+#else
+                       r = stat(a->name, &st);
+#endif
+                       if (r != 0)
                                r = errno;
+                       else if ((st.st_mode & AE_IFMT) == AE_IFREG) {
+                               a->fd = open(a->name, O_WRONLY | O_TRUNC |
+                                   O_BINARY | O_CLOEXEC | O_NOFOLLOW);
+                               __archive_ensure_cloexec_flag(a->fd);
+                               if (a->fd < 0)
+                                       r = errno;
+                       }
                }
                return (r);
 #endif