- [bug] Fixed the DropIndex construct to support

    an Index associated with a Table in a remote
    schema. [ticket:2571]

diff --git a/CHANGES b/CHANGES
index 0d421003de614da8176070ef9b4e3bef19adc521..2dab1c0189b6e696e32d11821ad73302044ab49f 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -46,6 +46,10 @@ CHANGES
     adding new content each time. [ticket:2566]
 
 - sql
+  - [bug] Fixed the DropIndex construct to support
+    an Index associated with a Table in a remote
+    schema. [ticket:2571]
+
   - [bug] Fixed CTE bug whereby positional
     bound parameters present in the CTEs themselves
     would corrupt the overall ordering of

diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py
index bd115314cf4a900a6676ee11c346768cb7730ffd..f45c9c896700f060d0b5f394b121f77411c1221c 100644 (file)
--- a/lib/sqlalchemy/sql/compiler.py
+++ b/lib/sqlalchemy/sql/compiler.py
@@ -1647,13 +1647,12 @@ class DDLCompiler(engine.Compiled):
             max = self.dialect.max_index_name_length or \
                         self.dialect.max_identifier_length
             if len(ident) > max:
-                return ident[0:max - 8] + \
+                ident = ident[0:max - 8] + \
                                 "_" + util.md5_hex(ident)[-4:]
-            else:
-                return ident
         else:
             self.dialect.validate_identifier(ident)
-            return ident
+
+        return ident
 
     def visit_create_index(self, create):
         index = create.element
@@ -1671,9 +1670,20 @@ class DDLCompiler(engine.Compiled):
 
     def visit_drop_index(self, drop):
         index = drop.element
-        return "\nDROP INDEX " + \
-                    self.preparer.quote(
-                            self._index_identifier(index.name), index.quote)
+        if index.table is not None and index.table.schema:
+            schema = index.table.schema
+            schema_name = self.preparer.quote_schema(schema,
+                                index.table.quote_schema)
+        else:
+            schema_name = None
+
+        index_name = self.preparer.quote(
+                            self._index_identifier(index.name),
+                                    index.quote)
+
+        if schema_name:
+            index_name = schema_name + "." + index_name
+        return "\nDROP INDEX " + index_name
 
     def visit_add_constraint(self, create):
         preparer = self.preparer

diff --git a/test/sql/test_constraints.py b/test/sql/test_constraints.py
index 8a82381399fc6f6991975b3d6cc917f400c5fd41..ed86dfe7d424962be99daabd375d5f60af41e87f 100644 (file)
--- a/test/sql/test_constraints.py
+++ b/test/sql/test_constraints.py
@@ -9,6 +9,7 @@ from test.lib.assertsql import AllOf, RegexSQL, ExactSQL, CompiledSQL
 from sqlalchemy.dialects.postgresql import base as postgresql
 
 class ConstraintTest(fixtures.TestBase, AssertsExecutionResults, AssertsCompiledSQL):
+    __dialect__ = 'default'
 
     def setup(self):
         global metadata
@@ -285,6 +286,44 @@ class ConstraintTest(fixtures.TestBase, AssertsExecutionResults, AssertsCompiled
             Index, "foo", SomeClass()
         )
 
+    def test_create_plain(self):
+        t = Table('t', MetaData(), Column('x', Integer))
+        i = Index("xyz", t.c.x)
+        self.assert_compile(
+            schema.CreateIndex(i),
+            "CREATE INDEX xyz ON t (x)"
+        )
+
+    def test_drop_plain_unattached(self):
+        self.assert_compile(
+            schema.DropIndex(Index(name="xyz")),
+            "DROP INDEX xyz"
+        )
+
+    def test_drop_plain(self):
+        t = Table('t', MetaData(), Column('x', Integer))
+        i = Index("xyz", t.c.x)
+        self.assert_compile(
+            schema.DropIndex(Index(name="xyz")),
+            "DROP INDEX xyz"
+        )
+
+    def test_create_schema(self):
+        t = Table('t', MetaData(), Column('x', Integer), schema="foo")
+        i = Index("xyz", t.c.x)
+        self.assert_compile(
+            schema.CreateIndex(i),
+            "CREATE INDEX xyz ON foo.t (x)"
+        )
+
+    def test_drop_schema(self):
+        t = Table('t', MetaData(), Column('x', Integer), schema="foo")
+        i = Index("xyz", t.c.x)
+        self.assert_compile(
+            schema.DropIndex(i),
+            "DROP INDEX foo.xyz"
+        )
+
 class ConstraintCompilationTest(fixtures.TestBase, AssertsCompiledSQL):
     __dialect__ = 'default'