]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
app_queue.c: Don't crash when realtime queue name is empty.
authorSean Bright <sean.bright@gmail.com>
Fri, 19 Mar 2021 20:57:44 +0000 (16:57 -0400)
committerJoshua Colp <jcolp@sangoma.com>
Mon, 22 Mar 2021 14:41:39 +0000 (09:41 -0500)
ASTERISK-27542 #close

Change-Id: If0b9719380a25533d2aed1053cff845dc3a4854a

apps/app_queue.c

index e84247dff07f653dfe239c20241690dadc729537..153fe6b0c3770500a1195d64a823ffc791475de5 100644 (file)
@@ -7697,6 +7697,10 @@ static int set_member_value(const char *queuename, const char *interface, int pr
                                char *category = NULL;
                                while ((category = ast_category_browse(queue_config, category))) {
                                        const char *name = ast_variable_retrieve(queue_config, category, "name");
+                                       if (ast_strlen_zero(name)) {
+                                               ast_log(LOG_WARNING, "Ignoring realtime queue with a NULL or empty 'name.'\n");
+                                               continue;
+                                       }
                                        if ((q = find_load_queue_rt_friendly(name))) {
                                                foundqueue++;
                                                foundinterface += set_member_value_help_members(q, interface, property, value);
@@ -9793,6 +9797,10 @@ static char *__queues_show(struct mansession *s, int fd, int argc, const char *
                        char *category = NULL;
                        while ((category = ast_category_browse(cfg, category))) {
                                const char *queuename = ast_variable_retrieve(cfg, category, "name");
+                               if (ast_strlen_zero(queuename)) {
+                                       ast_log(LOG_WARNING, "Ignoring realtime queue with a NULL or empty 'name.'\n");
+                                       continue;
+                               }
                                if ((q = find_load_queue_rt_friendly(queuename))) {
                                        queue_t_unref(q, "Done with temporary pointer");
                                }