]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/priority: use global define for default prio
authorVictor Julien <victor@inliniac.net>
Tue, 1 Oct 2019 12:05:08 +0000 (14:05 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 8 Oct 2019 18:31:09 +0000 (20:31 +0200)
src/detect-classtype.c
src/detect-parse.c
src/detect.h

index bd0dbbdb1c30fcc58b840897f53e0bd6b8cccbe4..5fbe689de3087eb9b42b9ab9b916dbb065586e0b 100644 (file)
@@ -116,12 +116,13 @@ static int DetectClasstypeSetup(DetectEngineCtx *de_ctx, Signature *s, const cha
     SCClassConfClasstype *ct = SCClassConfGetClasstype(parsed_ct_name, de_ctx);
     if (ct == NULL) {
         SCLogWarning(SC_ERR_UNKNOWN_VALUE, "unknown classtype: \"%s\", "
-                "using default priority 3", parsed_ct_name);
+                "using default priority %d",
+                parsed_ct_name, DETECT_DEFAULT_PRIO);
 
         char str[2048];
         snprintf(str, sizeof(str),
-                "config classification: %s,Unknown Classtype,3\n",
-                parsed_ct_name);
+                "config classification: %s,Unknown Classtype,%d\n",
+                parsed_ct_name, DETECT_DEFAULT_PRIO);
 
         if (SCClassConfAddClasstype(de_ctx, str, 0) < 0)
             return -1;
index caf2fa6435f6455b2b84866d77cdc332d8a10ee9..8c1f6bf194ac80fef851453a353c47ca1e70da07 100644 (file)
@@ -1800,7 +1800,7 @@ static Signature *SigInitHelper(DetectEngineCtx *de_ctx, const char *sigstr,
 
     /* signature priority hasn't been overwritten.  Using default priority */
     if (sig->prio == -1)
-        sig->prio = 3;
+        sig->prio = DETECT_DEFAULT_PRIO;
 
     sig->num = de_ctx->signum;
     de_ctx->signum++;
index c4babf91ffc4da380cd76ef40e42cbab3a27c841..ae936040b9c3a69d1184f7ced15876d73280effb 100644 (file)
 
 #define DETECT_TRANSFORMS_MAX 16
 
+/** default rule priority if not set through priority keyword or via
+ *  classtype. */
+#define DETECT_DEFAULT_PRIO 3
+
 /* forward declarations for the structures from detect-engine-sigorder.h */
 struct SCSigOrderFunc_;
 struct SCSigSignatureWrapper_;