]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RDMA/rtrs: Fix clt_path::max_pages_per_mr calculation
authorHonggang LI <honggangli@163.com>
Mon, 29 Dec 2025 02:56:17 +0000 (10:56 +0800)
committerLeon Romanovsky <leon@kernel.org>
Tue, 30 Dec 2025 10:47:32 +0000 (05:47 -0500)
If device max_mr_size bits in the range [mr_page_shift+31:mr_page_shift]
are zero, the `min3` function will set clt_path::max_pages_per_mr to
zero.

`alloc_path_reqs` will pass zero, which is invalid, as the third parameter
to `ib_alloc_mr`.

Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
Signed-off-by: Honggang LI <honggangli@163.com>
Link: https://patch.msgid.link/20251229025617.13241-1-honggangli@163.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/ulp/rtrs/rtrs-clt.c

index 71387811b2815822f1bea5c9f2ab0e4bc39aa2d9..2b397a544cb936334132e6cb5473afe38adcc1b8 100644 (file)
@@ -1464,6 +1464,7 @@ static void query_fast_reg_mode(struct rtrs_clt_path *clt_path)
        mr_page_shift      = max(12, ffs(ib_dev->attrs.page_size_cap) - 1);
        max_pages_per_mr   = ib_dev->attrs.max_mr_size;
        do_div(max_pages_per_mr, (1ull << mr_page_shift));
+       max_pages_per_mr = min_not_zero((u32)max_pages_per_mr, U32_MAX);
        clt_path->max_pages_per_mr =
                min3(clt_path->max_pages_per_mr, (u32)max_pages_per_mr,
                     ib_dev->attrs.max_fast_reg_page_list_len);