Bug 480968: Make checksetup.pl never show popup windows for errors, on Windows, to...

Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=Wurblzap, a=mkanat

diff --git a/Bugzilla/Install/Util.pm b/Bugzilla/Install/Util.pm
index 1f4a7c1b9e6543d12c41d1863ed8b7877b02328d..1c6d5c4ee7009b94f7bd6fd9646e0c243f2ece3d 100644 (file)
--- a/Bugzilla/Install/Util.pm
+++ b/Bugzilla/Install/Util.pm
@@ -548,6 +548,28 @@ sub init_console {
     eval { ON_WINDOWS && require Win32::Console::ANSI; };
     $ENV{'ANSI_COLORS_DISABLED'} = 1 if ($@ || !-t *STDOUT);
     $ENV{'HTTP_ACCEPT_LANGUAGE'} ||= get_console_locale();
+    prevent_windows_dialog_boxes();
+}
+
+sub prevent_windows_dialog_boxes {
+    # This code comes from http://bugs.activestate.com/show_bug.cgi?id=82183
+    # and prevents Perl modules from popping up dialog boxes, particularly
+    # during checksetup (since loading DBD::Oracle during checksetup when
+    # Oracle isn't installed causes a scary popup and pauses checksetup).
+    #
+    # Win32::API ships with ActiveState by default, though there could 
+    # theoretically be a Windows installation without it, I suppose.
+    if (ON_WINDOWS and eval { require Win32::API }) {
+        # Call kernel32.SetErrorMode with arguments that mean:
+        # "The system does not display the critical-error-handler message box.
+        # Instead, the system sends the error to the calling process." and
+        # "A child process inherits the error mode of its parent process."
+        my $SetErrorMode = Win32::API->new('kernel32', 'SetErrorMode', 
+                                           'I', 'I');
+        my $SEM_FAILCRITICALERRORS = 0x0001;
+        my $SEM_NOGPFAULTERRORBOX  = 0x0002;
+        $SetErrorMode->Call($SEM_FAILCRITICALERRORS | $SEM_NOGPFAULTERRORBOX);
+    }
 }
 
 # This is like request_cache, but it's used only by installation code