]> git.ipfire.org Git - thirdparty/httpx.git/commitdiff
Skip coverage on breaks right before returns for Python 3.8 (#226)
authorSeth Michael Larson <sethmichaellarson@gmail.com>
Sat, 17 Aug 2019 18:19:08 +0000 (13:19 -0500)
committerGitHub <noreply@github.com>
Sat, 17 Aug 2019 18:19:08 +0000 (13:19 -0500)
.travis.yml
httpx/config.py
httpx/dispatch/http11.py

index d702022c7d9b9f6a7397a1740331e75793b8a92e..4db0a0dfb1e870b1fbb2167dac270354b858adac 100644 (file)
@@ -22,9 +22,6 @@ matrix:
     - python: 3.8-dev
       env: NOX_SESSION=test-3.8
 
-  allow_failures:
-    - python: 3.8-dev
-
 install:
   - pip install --upgrade nox
 
index 6d427b85c38ac0fa03c76c636770ef8ae62d8a3d..796da35023a821f72a0ee7096525db80c7b08062 100644 (file)
@@ -148,7 +148,7 @@ class SSLConfig:
 
         if ssl.HAS_ALPN:
             context.set_alpn_protocols(["h2", "http/1.1"])
-        if ssl.HAS_NPN:
+        if ssl.HAS_NPN:  # pragma: no cover
             context.set_npn_protocols(["h2", "http/1.1"])
 
         return context
index 0f34191e975c7d5d7197035991112aefb707c61a..623ac1df6bfbc8affee3768dc753951fd962667e 100644 (file)
@@ -129,7 +129,7 @@ class HTTP11Connection:
                 continue
             else:
                 assert isinstance(event, h11.Response)
-                break
+                break  # pragma: no cover
         http_version = "HTTP/%s" % event.http_version.decode("latin-1", errors="ignore")
         return http_version, event.status_code, event.headers
 
@@ -145,7 +145,7 @@ class HTTP11Connection:
                 yield bytes(event.data)
             else:
                 assert isinstance(event, h11.EndOfMessage)
-                break
+                break  # pragma: no cover
 
     async def _receive_event(self, timeout: TimeoutConfig = None) -> H11Event:
         """
@@ -162,7 +162,8 @@ class HTTP11Connection:
                     data = b""
                 self.h11_state.receive_data(data)
             else:
-                break
+                assert event is not h11.NEED_DATA
+                break  # pragma: no cover
         return event
 
     async def response_closed(self) -> None: