]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/sched: Remove weak paused submission checks
authorTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Tue, 14 Jan 2025 10:59:42 +0000 (10:59 +0000)
committerPhilipp Stanner <phasta@kernel.org>
Thu, 16 Jan 2025 10:17:21 +0000 (11:17 +0100)
There is no need to check the boolean in the work item's prologues since
the boolean can be set at any later time anyway.

The helper which pauses submission sets it and synchronously cancels the
work and helpers which queue the work check for the flag so all should be
good.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Philipp Stanner <pstanner@redhat.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250114105942.64832-1-tvrtko.ursulin@igalia.com
drivers/gpu/drm/scheduler/sched_main.c

index 81d69c2ff6ab15daae3265c9ab86dea71be17191..d172e3158880bfb6d7922cfbd81b6a2ceadeadb1 100644 (file)
@@ -1153,9 +1153,6 @@ static void drm_sched_free_job_work(struct work_struct *w)
                container_of(w, struct drm_gpu_scheduler, work_free_job);
        struct drm_sched_job *job;
 
-       if (READ_ONCE(sched->pause_submit))
-               return;
-
        job = drm_sched_get_finished_job(sched);
        if (job)
                sched->ops->free_job(job);
@@ -1179,9 +1176,6 @@ static void drm_sched_run_job_work(struct work_struct *w)
        struct drm_sched_job *sched_job;
        int r;
 
-       if (READ_ONCE(sched->pause_submit))
-               return;
-
        /* Find entity with a ready job */
        entity = drm_sched_select_entity(sched);
        if (!entity)