]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: dsa: realtek: use devm_mutex_init for l2_lock
authorLuiz Angelo Daros de Luca <luizluca@gmail.com>
Mon, 27 Jul 2026 01:56:11 +0000 (22:56 -0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Jul 2026 01:42:27 +0000 (18:42 -0700)
With CONFIG_DEBUG_MUTEXES enabled, mutex_destroy() needs to be called
before the lock is discarded. Use devm_mutex_init() instead so the
cleanup is handled automatically.

Fixes: 336e3e4a1ab37 ("net: dsa: realtek: rtl8365mb: add FDB support")
Reviewed-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Alvin Šipraga <alvin.sipraga@analog.com>
Link: https://patch.msgid.link/20260726-realtek_mutext-v2-4-5d62ba998791@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/realtek/rtl83xx.c

index 9f40afb19ab26bfc3a70e20be31d89e8a8318d95..9dd50b20c000a05971d0dfba09a7072b7a933a1a 100644 (file)
@@ -164,7 +164,9 @@ rtl83xx_probe(struct device *dev,
        if (ret)
                return ERR_PTR(ret);
 
-       mutex_init(&priv->l2_lock);
+       ret = devm_mutex_init(dev, &priv->l2_lock);
+       if (ret)
+               return ERR_PTR(ret);
 
        rc.lock_arg = priv;
        priv->map = devm_regmap_init(dev, NULL, priv, &rc);