]> git.ipfire.org Git - thirdparty/ldns.git/commitdiff
Dangling else issie in close_socket define
authorWillem Toorop <willem@nlnetlabs.nl>
Tue, 29 Nov 2016 13:45:10 +0000 (14:45 +0100)
committerWillem Toorop <willem@nlnetlabs.nl>
Tue, 29 Nov 2016 13:45:10 +0000 (14:45 +0100)
Wouter's Review

configure.ac

index 19a3847edbf045a7256fd092d41b2aed9cd4d3d7..5afca7933160e96a7b1634ccae2bb3fd33046126 100644 (file)
@@ -882,10 +882,10 @@ size_t strlcpy(char *dst, const char *src, size_t siz);
 
 #ifdef USE_WINSOCK
 #define SOCK_INVALID INVALID_SOCKET
-#define close_socket(_s) if (_s > SOCK_INVALID) {closesocket(_s); _s = SOCK_INVALID;}
+#define close_socket(_s) do { if (_s > SOCK_INVALID) {closesocket(_s); _s = SOCK_INVALID;} } while(0)
 #else
 #define SOCK_INVALID -1
-#define close_socket(_s) if (_s > SOCK_INVALID) {close(_s); _s = SOCK_INVALID;}
+#define close_socket(_s) do { if (_s > SOCK_INVALID) {close(_s); _s = SOCK_INVALID;} } while(0)
 #endif
 
 #ifdef __cplusplus