]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
DNAME: add some comments to the unit tests
authorPieter Lexis <pieter.lexis@powerdns.com>
Wed, 6 Mar 2019 12:36:33 +0000 (13:36 +0100)
committerPieter Lexis <pieter.lexis@powerdns.com>
Thu, 7 Mar 2019 12:33:29 +0000 (13:33 +0100)
pdns/recursordist/test-syncres_cc.cc

index cba955f3c99686bed7daf6f14692ce0a284ba450..fbdb287a5b420977164ef4101f01e1689cbfd3cb 100644 (file)
@@ -11000,7 +11000,7 @@ BOOST_AUTO_TEST_CASE(test_dname_dnssec_secure) {
           setLWResult(res, 0, true, false, false);
           addRecordToLW(res, dnameOwner, QType::DNAME, dnameTarget.toString());
           addRRSIG(keys, res->d_records, dnameOwner, 300);
-          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString());
+          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString()); // CNAME from a DNAME is not signed
           return 1;
         }
       } else if (ip == ComboAddress("192.0.2.2:53")) {
@@ -11152,7 +11152,7 @@ BOOST_AUTO_TEST_CASE(test_dname_dnssec_insecure) {
           setLWResult(res, 0, true, false, false);
           addRecordToLW(res, dnameOwner, QType::DNAME, dnameTarget.toString());
           addRRSIG(keys, res->d_records, dnameOwner, 300);
-          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString());
+          addRecordToLW(res, domain, QType::CNAME, cnameTarget.toString()); // CNAME from a DNAME is not signed
           return 1;
         }
       } else if (ip == ComboAddress("192.0.2.2:53")) {