]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:utils: Fix misleading recursive flag in smbget error message gitlab/master
authorDESKTOP-73571CJ\User <hugochiaxyz.nus@gmail.com>
Wed, 11 Feb 2026 08:04:33 +0000 (16:04 +0800)
committerAnoop C S <anoopcs@samba.org>
Mon, 16 Feb 2026 15:37:04 +0000 (15:37 +0000)
The error message in smbget incorrectly instructs users to use "-R" for
recursive downloads.

In recent Samba versions, the "-R" flag was repurposed for
"--name-resolve" to align with other tools. The correct flag for
recursion is now "--recursive". This mismatch causes confusion as using
"-R" triggers a parameter parsing error rather than enabling recursion.

This patch updates the error string to correctly suggest "--recursive"
instead of "-R".

RN: smbget: Fix error message suggesting wrong flag for recursion.

Signed-off-by: Hugo Chia hugochiaxyz.nus@gmail.com
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Mon Feb 16 15:37:04 UTC 2026 on atb-devel-224

source3/utils/smbget.c

index d9744405bed1ad92e88e780fbcc54ac45d28f7c0..2ec5cf654ed79843f83cbd039695503ca494e759 100644 (file)
@@ -390,7 +390,7 @@ static bool smb_download_file(const char *base, const char *name,
                case EISDIR:
                        if (!recursive) {
                                fprintf(stderr,
-                                       "%s is a directory. Specify -R "
+                                       "%s is a directory. Specify --recursive "
                                        "to download recursively\n",
                                        path);
                                return false;