]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
app-layer-ssl: remove unnecessary length check
authorMats Klepsland <mats.klepsland@gmail.com>
Fri, 21 Sep 2018 05:25:19 +0000 (07:25 +0200)
committerMats Klepsland <mats.klepsland@gmail.com>
Fri, 21 Sep 2018 06:08:39 +0000 (08:08 +0200)
We already check that empty extensions are not decoded, so this length
check is not needed.

src/app-layer-ssl.c

index 4577c1d4c841d0368b12c396f3a902cc59941473..bd5833998d2635627aaef8a448e51adff44db380 100644 (file)
@@ -1184,8 +1184,7 @@ static inline int TLSDecodeHSHelloExtensions(SSLState *ssl_state,
 
             case SSL_EXTENSION_SESSION_TICKET:
             {
-                if ((ssl_state->current_flags & SSL_AL_FLAG_STATE_CLIENT_HELLO) &&
-                        ext_len != 0) {
+                if (ssl_state->current_flags & SSL_AL_FLAG_STATE_CLIENT_HELLO) {
                     /* This has to be verified later on by checking if a
                        certificate record has been sent by the server. */
                     ssl_state->flags |= SSL_AL_FLAG_SESSION_RESUMED;