]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
USB: serial: ftdi_sio: silence jtag probe
authorJohan Hovold <johan@kernel.org>
Mon, 10 Nov 2025 11:12:06 +0000 (12:12 +0100)
committerJohan Hovold <johan@kernel.org>
Mon, 17 Nov 2025 10:23:10 +0000 (11:23 +0100)
Probe of a device should generally be silent unless errors are
encountered.

Stop logging that the JTAG port is ignored when probing devices with
such a reserved port.

This also maintains consistency with devices that match on interface
number to avoid binding to reserved ports.

Note that the message is not even correct for the second port of the ST
Micro Connect Lite.

Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/ftdi_sio.c

index 36c8830281b9422d2ad4b32b8ad7d17e6728101c..05b3c558d1e2931060bf993855c375f2663d5cb4 100644 (file)
@@ -2294,10 +2294,8 @@ static int ftdi_jtag_probe(struct usb_serial *serial)
        struct usb_interface *intf = serial->interface;
        int ifnum = intf->cur_altsetting->desc.bInterfaceNumber;
 
-       if (ifnum == 0) {
-               dev_info(&intf->dev, "Ignoring interface reserved for JTAG\n");
+       if (ifnum == 0)
                return -ENODEV;
-       }
 
        return 0;
 }
@@ -2330,10 +2328,8 @@ static int ftdi_stmclite_probe(struct usb_serial *serial)
        struct usb_interface *intf = serial->interface;
        int ifnum = intf->cur_altsetting->desc.bInterfaceNumber;
 
-       if (ifnum < 2) {
-               dev_info(&intf->dev, "Ignoring interface reserved for JTAG\n");
+       if (ifnum < 2)
                return -ENODEV;
-       }
 
        return 0;
 }