]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Ensure we properly release DTLS buffered app data records
authorMatt Caswell <matt@openssl.org>
Fri, 2 May 2025 15:37:32 +0000 (16:37 +0100)
committerTodd Short <todd.short@me.com>
Thu, 8 May 2025 18:16:39 +0000 (14:16 -0400)
If we read an app data record before we have read the Finished we buffer
it. Once we've read it we need to make sure we've properly released it
otherwise we will attempt to read it again (and this time there will be
no data in it).

Fixes #27316

Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from https://github.com/openssl/openssl/pull/27543)

(cherry picked from commit d459d00f97959d5003b29f32d52a53208507cda1)

ssl/record/rec_layer_s3.c

index 55e19bd0cdc671ebc7b0c83b963bd1006e5b529f..89413a5a93c77c8a8701348db1b064c4bc0cab63 100644 (file)
@@ -568,6 +568,7 @@ int ssl_release_record(SSL_CONNECTION *s, TLS_RECORD *rr, size_t length)
         /* We allocated the buffers for this record (only happens with DTLS) */
         OPENSSL_free(rr->allocdata);
         rr->allocdata = NULL;
+        s->rlayer.curr_rec++;
     }
     rr->length -= length;
     if (rr->length > 0)