re PR c++/28343 (ICE with invalid asm specifier for struct member)

	PR c++/28343
	* decl.c (cp_finish_decl): Check asmspec_tree for error_mark_node.
	* decl2.c (grokfield): Likewise.

	* g++.dg/ext/asmspec1.C: New test.

From-SVN: r115438

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 5dd905fbdf9ba5bd8df11e54428d526ae4d47bbe..69b83d4efe09667434e04800663e1a157ae47fa6 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2006-07-14  Volker Reichelt  <reichelt@igpm.rwth-aachen.de>
+
+       PR c++/28343
+       * decl.c (cp_finish_decl): Check asmspec_tree for error_mark_node.
+       * decl2.c (grokfield): Likewise.
+
 2006-07-12  Steve Ellcey  <sje@cup.hp.com>
 
        PR c++/28114
@@ -6,11 +12,11 @@
 2006-07-11  Lee Millward  <lee.millward@gmail.com>
 
        PR c++/28051
-       * mangle.c (mangle_conv_op_name_for_type): Check for
-       invalid types.
-       * name-lookup.c (push_class_level_binding): Robustify.
-       (do_class_using_decl): Return early if name is
-       error_mark_node.
+       * mangle.c (mangle_conv_op_name_for_type): Check for
+       invalid types.
+       * name-lookup.c (push_class_level_binding): Robustify.
+       (do_class_using_decl): Return early if name is
+       error_mark_node.
        
 2006-07-10  Jason Merrill  <jason@redhat.com>
 
@@ -18,7 +24,7 @@
 
 2006-07-08  Lee Millward  <lee.millward@gmail.com>
            Andrew Pinski  <pinskia@gmail.com>
-       
+
        PR c++/27820
        * decl.c (define_label): Return error_mark_node on error.
        * semantics.c (finish_label_stmt): Don't call

diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index 4fc6d624bc38212a315fabfaf4cf58c1106be6ba..af1407c728ad5f8a3028afc1df5ff824248c9243 100644 (file)
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -4752,7 +4752,7 @@ cp_finish_decl (tree decl, tree init, bool init_const_expr_p,
   /* If a name was specified, get the string.  */
   if (global_scope_p (current_binding_level))
     asmspec_tree = maybe_apply_renaming_pragma (decl, asmspec_tree);
-  if (asmspec_tree)
+  if (asmspec_tree && asmspec_tree != error_mark_node)
     asmspec = TREE_STRING_POINTER (asmspec_tree);
 
   if (init && TREE_CODE (init) == NAMESPACE_DECL)

diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c
index 7aa7af9b13025b071ec8a6b691a1ddc90847b26d..776d8baabdaa951c49fb0e2974c4216191735271 100644 (file)
--- a/gcc/cp/decl2.c
+++ b/gcc/cp/decl2.c
@@ -900,7 +900,7 @@ grokfield (const cp_declarator *declarator,
       return void_type_node;
     }
 
-  if (asmspec_tree)
+  if (asmspec_tree && asmspec_tree != error_mark_node)
     asmspec = TREE_STRING_POINTER (asmspec_tree);
 
   if (init)

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 088a3af63340e98da60cbf4c25ff15ee13a33cec..919074d932e06bf46f78251f8f31c5e109b948c6 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2006-07-14  Volker Reichelt  <reichelt@igpm.rwth-aachen.de>
+
+       PR c++/28343
+       * g++.dg/ext/asmspec1.C: New test.
+
 2006-07-12  Steve Ellcey  <sje@cup.hp.com>
 
        PR c++/28114

diff --git a/gcc/testsuite/g++.dg/ext/asmspec1.C b/gcc/testsuite/g++.dg/ext/asmspec1.C
new file mode 100644 (file)
index 0000000..3df2483
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/asmspec1.C
@@ -0,0 +1,8 @@
+// PR c++/28343
+// { dg-do compile }
+
+struct A
+{
+  int i __asm__(int);         // { dg-error "before" }
+  static int j __asm__(int);  // { dg-error "before" }
+};