'tql' must be non NULL, remove test.

255 flag_fail:
256        /* get rid of what was build of the query list */

	CID 1452697 (#1 of 1): Dereference before null check (REVERSE_INULL)
	check_after_deref: Null-checking tql suggests that it may
	be null, but it has already been dereferenced on all paths
	leading to the check.

257        if (tql != NULL)
258                destroy_querylist(mctx, &tql);

diff --git a/contrib/dlz/drivers/sdlz_helper.c b/contrib/dlz/drivers/sdlz_helper.c
index 889a8a6ee876120d9312606bfeb615b5e1d86478..6eb66292457f071098e4e6b9ed755ac62ae4c4b7 100644 (file)
--- a/contrib/dlz/drivers/sdlz_helper.c
+++ b/contrib/dlz/drivers/sdlz_helper.c
@@ -254,8 +254,7 @@ build_querylist(isc_mem_t *mctx, const char *query_str, char **zone,
 
  flag_fail:
        /* get rid of what was build of the query list */
-       if (tql != NULL)
-               destroy_querylist(mctx, &tql);
+       destroy_querylist(mctx, &tql);
        return result;
 }