]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: omap3isp: support ctrl events for isppreview
authorHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 7 Oct 2025 14:18:28 +0000 (16:18 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 6 Jan 2026 07:22:46 +0000 (08:22 +0100)
The preview subdev device was missing V4L2_SUBDEV_FL_HAS_EVENTS,
and that prevented VIDIOC_SUBSCRIBE_EVENT from working.

Fixes a v4l2-compliance error:

fail: v4l2-test-controls.cpp(1128): subscribe event for control 'User Controls' failed
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL

Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
drivers/media/platform/ti/omap3isp/isppreview.c

index 9992db782870b0268b88992888d288fed8aadf61..3e9e213c6d8ab98885068869d9eff2dbc5583063 100644 (file)
@@ -2277,7 +2277,7 @@ static int preview_init_entities(struct isp_prev_device *prev)
        strscpy(sd->name, "OMAP3 ISP preview", sizeof(sd->name));
        sd->grp_id = 1 << 16;   /* group ID for isp subdevs */
        v4l2_set_subdevdata(sd, prev);
-       sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
+       sd->flags |= V4L2_SUBDEV_FL_HAS_EVENTS | V4L2_SUBDEV_FL_HAS_DEVNODE;
 
        v4l2_ctrl_handler_init(&prev->ctrls, 2);
        v4l2_ctrl_new_std(&prev->ctrls, &preview_ctrl_ops, V4L2_CID_BRIGHTNESS,