]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fail when spatch can't process source code
authorMichal Nowak <mnowak@isc.org>
Mon, 20 Oct 2025 15:36:36 +0000 (17:36 +0200)
committerMichal Nowak <mnowak@isc.org>
Wed, 22 Oct 2025 10:50:55 +0000 (12:50 +0200)
Sometimes spatch fails to process the source code:

    EXN: Failure("replacement: node 80: {7[1,2,30,31,32] in isc__nm_base64_to_base64url reachable by inconsistent control-flow paths") in ./lib/isc/netmgr/http.c

util/check-cocci.sh

index 5dd382c6ad58d33199485acc9a42fbeec22eb40f..09783ea9af34a18fcd543b8888de741550c42f67 100755 (executable)
@@ -23,7 +23,7 @@ run_spatch() {
   echo "Applying semantic patch $spatch..."
   spatch --jobs "${TEST_PARALLEL_JOBS:-1}" --sp-file "$spatch" --use-gitgrep --dir "." --include-headers $spatchargs >>"$patch" 2>cocci.stderr
   cat cocci.stderr
-  if grep -q -e "parse error" cocci.stderr; then
+  if grep -q -e "parse error" -e "EXN: Failure" cocci.stderr; then
     ret=1
   fi
   if [ "$(wc <"$patch" -l)" -gt "0" ]; then