]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
issue 4483 - dbm build failures on systems with gdbm_compat lib.
authorSkip Montanaro <skip@pobox.com>
Sat, 6 Dec 2008 17:43:30 +0000 (17:43 +0000)
committerSkip Montanaro <skip@pobox.com>
Sat, 6 Dec 2008 17:43:30 +0000 (17:43 +0000)
Misc/NEWS
Modules/dbmmodule.c
setup.py

index 1a70e3183b66efb3109dcbe6cb71dd032fd619e2..e916d08def797dc95aad083f52ad2e8e8e7e725a 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -65,6 +65,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #4483: _dbm module now builds on systems with gdbm & gdbm_compat
+  libs.
+
 - Issue #4529: fix the parser module's validation of try-except-finally
   statements.
 
index c91ea471a05e0d3876cafc806df807e22d80bb20..0c50b5454c2ad4e1aaafdbc86e4869c5f7880d53 100644 (file)
@@ -21,6 +21,9 @@ static char *which_dbm = "GNU gdbm";  /* EMX port of GDBM */
 #elif defined(HAVE_GDBM_NDBM_H)
 #include <gdbm/ndbm.h>
 static char *which_dbm = "GNU gdbm";
+#elif defined(HAVE_GDBM_DASH_NDBM_H)
+#include <gdbm-ndbm.h>
+static char *which_dbm = "GNU gdbm";
 #elif defined(HAVE_BERKDB_H)
 #include <db.h>
 static char *which_dbm = "Berkeley DB";
index 5c37e4553f2a1c538e852c5fb020fd0cd45fcc48..e7d3ad3ba57aa8697b335ca708c01c82e9aee0de 100644 (file)
--- a/setup.py
+++ b/setup.py
@@ -1019,8 +1019,20 @@ class PyBuildExt(build_ext):
                 exts.append( Extension('dbm', ['dbmmodule.c'],
                                        define_macros=[('HAVE_NDBM_H',None)],
                                        libraries = ndbm_libs ) )
-            elif (self.compiler.find_library_file(lib_dirs, 'gdbm')
-                  and find_file("gdbm/ndbm.h", inc_dirs, []) is not None):
+            elif self.compiler.find_library_file(lib_dirs, 'gdbm'):
+                gdbm_libs = ['gdbm']
+                if self.compiler.find_library_file(lib_dirs, 'gdbm_compat'):
+                    gdbm_libs.append('gdbm_compat')
+                if find_file("gdbm/ndbm.h", inc_dirs, []) is not None:
+                    exts.append( Extension(
+                        'dbm', ['dbmmodule.c'],
+                        define_macros=[('HAVE_GDBM_NDBM_H',None)],
+                        libraries = gdbm_libs ) )
+                elif find_file("gdbm-ndbm.h", inc_dirs, []) is not None:
+                    exts.append( Extension(
+                        'dbm', ['dbmmodule.c'],
+                        define_macros=[('HAVE_GDBM_DASH_NDBM_H',None)],
+                        libraries = gdbm_libs ) )
                 exts.append( Extension('dbm', ['dbmmodule.c'],
                                        define_macros=[('HAVE_GDBM_NDBM_H',None)],
                                        libraries = ['gdbm'] ) )