]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: remove unnecessary else after break
authorVo Thanh Cong <thanhcongvo079@gmail.com>
Tue, 13 Jan 2026 10:37:38 +0000 (17:37 +0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Jan 2026 13:00:03 +0000 (14:00 +0100)
This patch fixes the checkpatch.pl warning:
"WARNING: else is not generally useful after a break or return"

In sdio_ops_linux.c, the else blocks after break statements are
redundant. Removing them reduces indentation level and improves
code readability.

Signed-off-by: Vo Thanh Cong <thanhcongvo079@gmail.com>
Link: https://patch.msgid.link/20260113103738.207570-1-thanhcongvo079@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c

index 5dc00e9117ae516ba61d9559830190885c84990d..3ea9fdfa14f862a64738c57a2418911d6919ee65 100644 (file)
@@ -219,14 +219,14 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s32 *err)
                        if (*err == 0) {
                                rtw_reset_continual_io_error(psdiodev);
                                break;
-                       } else {
-                               if ((-ESHUTDOWN == *err) || (-ENODEV == *err))
-                                       padapter->bSurpriseRemoved = true;
-
-                               if (rtw_inc_and_chk_continual_io_error(psdiodev) == true) {
-                                       padapter->bSurpriseRemoved = true;
-                                       break;
-                               }
+                       }
+
+                       if ((-ESHUTDOWN == *err) || (-ENODEV == *err))
+                               padapter->bSurpriseRemoved = true;
+
+                       if (rtw_inc_and_chk_continual_io_error(psdiodev) == true) {
+                               padapter->bSurpriseRemoved = true;
+                               break;
                        }
                }
        }
@@ -295,14 +295,14 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, u32 v, s32 *err)
                        if (*err == 0) {
                                rtw_reset_continual_io_error(psdiodev);
                                break;
-                       } else {
-                               if ((-ESHUTDOWN == *err) || (-ENODEV == *err))
-                                       padapter->bSurpriseRemoved = true;
-
-                               if (rtw_inc_and_chk_continual_io_error(psdiodev) == true) {
-                                       padapter->bSurpriseRemoved = true;
-                                       break;
-                               }
+                       }
+
+                       if ((-ESHUTDOWN == *err) || (-ENODEV == *err))
+                               padapter->bSurpriseRemoved = true;
+
+                       if (rtw_inc_and_chk_continual_io_error(psdiodev) == true) {
+                               padapter->bSurpriseRemoved = true;
+                               break;
                        }
                }
        }