]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: rockchip-samsung-dcphy: Discard pm_runtime_put() return value
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 22 Dec 2025 20:21:30 +0000 (21:21 +0100)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Dec 2025 17:41:03 +0000 (23:11 +0530)
Passing pm_runtime_put() return value to the callers is not particularly
useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update samsung_mipi_dcphy_exit() to simply discard the
return value of pm_runtime_put() and always return success to the
caller.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2281919.Icojqenx9y@rafael.j.wysocki
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c

index 4508a314727232473e90fd1649ec0f2829b65c49..0f69060aa5d555580662a7d849009e09f68d8006 100644 (file)
@@ -1508,7 +1508,9 @@ static int samsung_mipi_dcphy_exit(struct phy *phy)
 {
        struct samsung_mipi_dcphy *samsung = phy_get_drvdata(phy);
 
-       return pm_runtime_put(samsung->dev);
+       pm_runtime_put(samsung->dev);
+
+       return 0;
 }
 
 static const struct phy_ops samsung_mipi_dcphy_ops = {