]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
process_test: Remove compatibility hack for python 3.13 beta 1 3395/head
authorBen Darnell <ben@bendarnell.com>
Mon, 10 Jun 2024 16:09:20 +0000 (12:09 -0400)
committerBen Darnell <ben@bendarnell.com>
Mon, 10 Jun 2024 16:28:35 +0000 (12:28 -0400)
.github/workflows/test.yml
tornado/test/process_test.py

index 53d4b4c6f308acf9d23d855429294bfac33eb6d3..83de720da4b639f5dc959f1af150c1daa95bfd25 100644 (file)
@@ -53,7 +53,7 @@ jobs:
             tox_env: py311-full
           - python: '3.12.0'
             tox_env: py312-full
-          - python: '3.13.0-beta.1 - 3.13'
+          - python: '3.13.0-beta.2 - 3.13'
             # Some optional dependencies don't seem to work on 3.13 yet
             tox_env: py313
           - python: 'pypy-3.8'
index 8b1f8635f43ccaa7da8d103c7ce2e8d4b0f93b60..0fdb941850c3824301307a13bda148c90540e418 100644 (file)
@@ -140,19 +140,11 @@ class SubprocessTest(AsyncTestCase):
 
     @gen_test
     def test_subprocess(self):
-        # In Python 3.13.0b1, the new repl logs an error on exit if terminfo
-        # doesn't exist, the -i flag is used, and stdin is not a tty. This bug may
-        # have been fixed in beta 2, so for now we disable the new repl in this test
-        # and the next. Once we've tested with beta 2 we can either remove this env var
-        # or file a bug upstream if it still exists.
-        env = dict(os.environ)
-        env["PYTHON_BASIC_REPL"] = "1"
         subproc = Subprocess(
             [sys.executable, "-u", "-i"],
             stdin=Subprocess.STREAM,
             stdout=Subprocess.STREAM,
             stderr=subprocess.STDOUT,
-            env=env,
         )
         self.addCleanup(lambda: self.term_and_wait(subproc))
         self.addCleanup(subproc.stdout.close)
@@ -170,14 +162,11 @@ class SubprocessTest(AsyncTestCase):
     @gen_test
     def test_close_stdin(self):
         # Close the parent's stdin handle and see that the child recognizes it.
-        env = dict(os.environ)
-        env["PYTHON_BASIC_REPL"] = "1"
         subproc = Subprocess(
             [sys.executable, "-u", "-i"],
             stdin=Subprocess.STREAM,
             stdout=Subprocess.STREAM,
             stderr=subprocess.STDOUT,
-            env=env,
         )
         self.addCleanup(lambda: self.term_and_wait(subproc))
         yield subproc.stdout.read_until(b">>> ")