]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: davinci_mdio: use new iterator mdiobus_for_each_phy
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 25 Oct 2025 18:52:09 +0000 (20:52 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Oct 2025 02:00:34 +0000 (19:00 -0700)
Use new iterator mdiobus_for_each_phy() to simplify the code.

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/326d1337-2c22-42e3-a152-046ac5c43095@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/davinci_mdio.c

index 9f049ebbf10794a84d6abac8b6d8804648e5eb67..48f85a3649b265484c7aebc05cfc756d10b62af0 100644 (file)
@@ -541,8 +541,8 @@ static int davinci_mdio_probe(struct platform_device *pdev)
        struct davinci_mdio_data *data;
        struct resource *res;
        struct phy_device *phy;
-       int ret, addr;
        int autosuspend_delay_ms = -1;
+       int ret;
 
        data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
        if (!data)
@@ -645,14 +645,10 @@ static int davinci_mdio_probe(struct platform_device *pdev)
                goto bail_out;
 
        /* scan and dump the bus */
-       for (addr = 0; addr < PHY_MAX_ADDR; addr++) {
-               phy = mdiobus_get_phy(data->bus, addr);
-               if (phy) {
-                       dev_info(dev, "phy[%d]: device %s, driver %s\n",
-                                phy->mdio.addr, phydev_name(phy),
-                                phy->drv ? phy->drv->name : "unknown");
-               }
-       }
+       mdiobus_for_each_phy(data->bus, phy)
+               dev_info(dev, "phy[%d]: device %s, driver %s\n",
+                        phy->mdio.addr, phydev_name(phy),
+                        phy->drv ? phy->drv->name : "unknown");
 
        return 0;