[Bug 1127] Properly check the return of X590_verify() - missed one

bk: 4b36f34bL--O3TdMkIlepoItxt2wVg

diff --git a/ChangeLog b/ChangeLog
index b7300bdfc02afe6622f26cb223f09e9843de748b..007d11af1a8b9b7b2a429bac55c93c6d25ef72eb 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,7 @@
 ---
 (4.2.6p1-RC2) 2009/12/25 Released by Harlan Stenn <stenn@ntp.org>
 
+* [Bug 1127] Properly check the return of X590_verify() - missed one.
 * [Bug 1411] Fix status messages in refclock_oncore.c.
 * [Bug 1416] MAXDNAME undefined on Solaris 2.6.
 * [Bug 1419] ntpdate, ntpdc, sntp, ntpd ignore configure --bindir.

diff --git a/util/ntp-keygen.c b/util/ntp-keygen.c
index 3a85f0dc2660b38fde3e93c71f38afd9f8fd12aa..dd6b6549e301a23b8e5d6127e35dbd275047afd5 100644 (file)
--- a/util/ntp-keygen.c
+++ b/util/ntp-keygen.c
@@ -1926,7 +1926,7 @@ x509      (
         * Sign and verify.
         */
        X509_sign(cert, pkey, md);
-       if (!X509_verify(cert, pkey)) {
+       if (X509_verify(cert, pkey) <= 0) {
                fprintf(stderr, "Verify %s certificate fails\n%s\n", id,
                    ERR_error_string(ERR_get_error(), NULL));
                X509_free(cert);