ASoC: simple-card-utils: remove both playback/capture_only check

soc-pcm.c :: soc_get_playback_capture() will indicate error
if both playback_only / capture_only were true.

Thus, graph_util_parse_link_direction() which setup playback_only /
capture_only don't need to check it.
And, its return value is not used on existing driver. Let's remove it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://msgid.link/r/87a5kah6gm.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h
index 2c2279d082ec4b1ebf97d61e4c2ecb3319133fd0..0a6435ac5c5fe3331a50841d09d3d140b6eca079 100644 (file)
--- a/include/sound/simple_card_utils.h
+++ b/include/sound/simple_card_utils.h
@@ -197,7 +197,7 @@ int graph_util_is_ports0(struct device_node *port);
 int graph_util_parse_dai(struct device *dev, struct device_node *ep,
                         struct snd_soc_dai_link_component *dlc, int *is_single_link);
 
-int graph_util_parse_link_direction(struct device_node *np,
+void graph_util_parse_link_direction(struct device_node *np,
                                    bool *is_playback_only, bool *is_capture_only);
 
 #ifdef DEBUG

diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index 852989611362d525e986c25de93762c72de11dcc..bc4d518c35cb4a03084ee62417aeec09beb058c8 100644 (file)
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -1140,7 +1140,7 @@ parse_dai_end:
 }
 EXPORT_SYMBOL_GPL(graph_util_parse_dai);
 
-int graph_util_parse_link_direction(struct device_node *np,
+void graph_util_parse_link_direction(struct device_node *np,
                                    bool *playback_only, bool *capture_only)
 {
        bool is_playback_only = false;
@@ -1149,13 +1149,8 @@ int graph_util_parse_link_direction(struct device_node *np,
        is_playback_only = of_property_read_bool(np, "playback-only");
        is_capture_only = of_property_read_bool(np, "capture-only");
 
-       if (is_playback_only && is_capture_only)
-               return -EINVAL;
-
        *playback_only = is_playback_only;
        *capture_only = is_capture_only;
-
-       return 0;
 }
 EXPORT_SYMBOL_GPL(graph_util_parse_link_direction);