]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: mediatek: paris: Skip custom extra pin config dump for virtual GPIOs
authorChen-Yu Tsai <wenst@chromium.org>
Tue, 8 Mar 2022 10:09:51 +0000 (18:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:06:26 +0000 (14:06 +0200)
[ Upstream commit 1763933d377ecb05454f8d20e3c8922480db2ac0 ]

Virtual GPIOs do not have any hardware state associated with them. Any
attempt to read back hardware state for these pins result in error
codes.

Skip dumping extra pin config information for these virtual GPIOs.

Fixes: 184d8e13f9b1 ("pinctrl: mediatek: Add support for pin configuration dump via debugfs.")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220308100956.2750295-7-wenst@chromium.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/mediatek/pinctrl-paris.c

index faf11c9e1db3e8855c1f90435c59ae013456957b..154d55a239e8399e643663b40e716a27282834c8 100644 (file)
@@ -581,6 +581,9 @@ ssize_t mtk_pctrl_show_one_pin(struct mtk_pinctrl *hw,
        if (gpio >= hw->soc->npins)
                return -EINVAL;
 
+       if (mtk_is_virt_gpio(hw, gpio))
+               return -EINVAL;
+
        desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio];
        pinmux = mtk_pctrl_get_pinmux(hw, gpio);
        if (pinmux >= hw->soc->nfuncs)