]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: migration: Remove TODO about implementing NBD for TUNNELLED migration
authorPeter Krempa <pkrempa@redhat.com>
Tue, 24 Nov 2020 07:04:36 +0000 (08:04 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 24 Nov 2020 16:59:26 +0000 (17:59 +0100)
Our streams are not the best transport for migration data and we support
TLS for security now. It's unlikely that there will be enough motivation
to add a new migration protocol to tunnel NBD too.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_migration.c

index fef0be63a1a76d7b32271eaaf40fc276f282f57c..85f3c4cceeab8b92247db81919947d85028ad179 100644 (file)
@@ -2244,10 +2244,7 @@ qemuMigrationSrcBeginPhase(virQEMUDriverPtr driver,
             }
         }
 
-        /* TODO support NBD for TUNNELLED migration */
-        if (flags & VIR_MIGRATE_TUNNELLED) {
-            VIR_WARN("NBD in tunnelled migration is currently not supported");
-        } else {
+        if (!(flags & VIR_MIGRATE_TUNNELLED)) {
             cookieFlags |= QEMU_MIGRATION_COOKIE_NBD;
             priv->nbdPort = 0;
         }